search

fivetran / dbt_marketo

Fivetran's Marketo dbt package
https://fivetran.github.io/dbt_marketo/
Apache License 2.0
8 stars 7 forks source link

Feature/databricks compatibility #22

Closed fivetran-catfritz closed 2 years ago

fivetran-catfritz commented 2 years ago

Pull Request Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

PR https://github.com/fivetran/dbt_marketo/pull/22 incorporates the following updates:

🚨 Breaking Changes 🚨 Some of the more complex transformation logic has been moved from the Marketo source package to the transform package. This was done so the delineation between staging and intermediate models is in line with Fivetran's other packages. This does not affect the final tables created by the transform package, but this will affect the staging tables as outlined below.

Model stg_marketolead_base from dbt_marketo_source has been rolled into [stg_marketolead](https://github.com/fivetran/dbt_marketo_source/blob/main/models/stg_marketo__lead.sql). Parts from model stg_marketo__lead from dbt_marketo_source have been moved to a new model int_marketo__lead in dbt_marketo. Features 🎉 Databricks compatibility 🎉 Ability to disable activity_delete_lead model if necessary (see README for instructions). Updated structure of config default variables for enabling campaigns and program models to avoid conflicting with a user's settings.

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Tested locally using the below in my dbt_project.yml to make sure turning these models on and off worked appropriately after the changes:

vars:
    marketo__enable_campaigns:   true    # Default is false
    marketo__enable_programs:     true    # Default is false
    marketo__activity_delete_lead_enabled:  false    # Default is true

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

🌴 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-catfritz commented 2 years ago
  • The docs for this package seem to be hosted on the old Netlify site. We now want to host our docs using GitHub pages. You can use our directions on how to setup GitHub pages for this package.

Just a note that I will do this after merging with main.

fivetran-catfritz commented 2 years ago

Also added postgres test and target to integration testing.