fivetran / dbt_microsoft_ads

Fivetran data transformations for Microsoft (Bing) Ads built using dbt.
https://fivetran.github.io/dbt_microsoft_ads/
Apache License 2.0
3 stars 6 forks source link

fix search report uniqueness + anticipate microsoft historical hard-deletes #21

Closed fivetran-jamie closed 1 year ago

fivetran-jamie commented 1 year ago

Pull Request Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

🎃 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-sheringuyen commented 1 year ago

Overall - LGTM, I would like to hold off on merging until Clay gets a chance to try out this branch but ow, it looks good to me with the above minor suggestions if you'd like to add them.

fivetran-jamie commented 1 year ago

will merge after buildkite runs and i resolve docs conflicts