fivetran / dbt_microsoft_ads

Fivetran data transformations for Microsoft (Bing) Ads built using dbt.
https://fivetran.github.io/dbt_microsoft_ads/
Apache License 2.0
3 stars 6 forks source link

Bugfix/match type report adjustments #23

Closed fivetran-joemarkiewicz closed 1 year ago

fivetran-joemarkiewicz commented 1 year ago

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

🪳 Bugfix 🪳

This PR includes the following bug fixes:

Contributors:

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

🧉 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 1 year ago

LGTM! one q though - do we want to note that records with non-null _id fields and null _name fields reflect entities hard-deleted by microsoft? i suppose it's in the changelog, but maybe we wanna add it as well to the readme or decision log or something?

That's a great point. I will add a similar note from the CHANGELOG into the DECISIONLOG so it is not lost to time.

fivetran-jamie commented 1 year ago

ah .DS_Store snuck in there @fivetran-joemarkiewicz

fivetran-joemarkiewicz commented 1 year ago

ah .DS_Store snuck in there @fivetran-joemarkiewicz

Ahhh good eye, just removed it.