[Feature] Please add Netsuite2 pass-through column support for job object

fivetran / dbt_netsuite

Data models for Fivetran's Netsuite connector, built using dbt.

https://fivetran.github.io/dbt_netsuite/

Apache License 2.0

36 stars 34 forks source link

[Feature] Please add Netsuite2 pass-through column support for job object #101

Open wardw123 opened 8 months ago

wardw123 commented 8 months ago

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature

Please add Netsuite2 pass-through column support for job object, similar to the pass through functionality for other netsuite_source objects. Thanks!

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

[ ] Yes.
[X] Yes, but I will need assistance and will schedule time during your office hours for guidance.
[ ] No.

Anything else?

No response

wardw123 commented 8 months ago

If it helps, I mocked up a new version of the stg_netsuite2__jobs.sql file as well as the get_job_columns.yml macro that I believe does the trick! Files are attached in a zip file. It seemed to do the trick without breaking anything!

Netsuite Jobs with passthrough.zip

Screen Shot 2023-12-21 at 5 24 48 PM

fivetran-avinash commented 8 months ago

Hi @wardw123! Thanks for investigating the best approach here. I took a look and it seems like that your approach would be the best way to get passthrough columns into the job object.

If you are able to open a PR on the dbt_netsuite_source package with these changes, we can take a look, approve it, and get it ready to merge. Make sure you complete all the steps in the pull request template form (it should show up once you've pushed your branch) before submitting. Let us know if you have questions!