DECISIONLOG re: null converted amounts - Githubissues

fivetran / dbt_netsuite

Data models for Fivetran's Netsuite connector, built using dbt.

https://fivetran.github.io/dbt_netsuite/

Apache License 2.0

36 stars 34 forks source link

DECISIONLOG re: null converted amounts #118

Closed fivetran-avinash closed 4 months ago

fivetran-avinash commented 4 months ago

PR Overview

This PR will address the following Issue/Feature: [#

This PR will result in the following new package version:

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

📝 Documentation Update 📝

Updated DECISIONLOG with our reasoning for why we don't bring in future-facing transactions and leave the converted_amount in transaction details empty. (#115)
PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:
[NA] dbt run –full-refresh && dbt test
[NA] dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

[x] The appropriate issue has been linked, tagged, and properly assigned
[x] -All necessary documentation and version upgrades have been applied
[NA] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[x] Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Just a documentation update