fivetran-joemarkiewicz
commented
3 months ago Hey @tom-rb thanks for opening this feature request!
I definitely can understand the desire to include the location information in the transaction detail end model. I also don't imagine this addition would cause any disruption to the granularity tests and should work by taking the approach you mentioned of including the fivetran_utils.persist_pass_through_columns() macro in the end model. The only other change I would recommend making is to include the location_id by default in the end model. This way, if users are not familiar or comfortable using the variables to passthrough columns, they can also more easily leverage the location_id to perform the join without needing to take the non ideal workaround you mentioned.
I see you are open to creating a PR! If you are open to contributing this change we would happily review it and plan to integrate into the next release once all is approved. Otherwise, we will plan to add this to our backlog and pick it up once we have capacity or if we see a high demand for this FR. The changes I recommend applying are as follows:
- Include
transaction_lines.location_idhere. - Add the below macro/variable to below the default location fields.
--The below script allows for locations table pass through columns. {{ fivetran_utils.persist_pass_through_columns('locationss_pass_through_columns', identifier='locations') }},
With those updates applied, and if you can confirm all looks good on your end, then this would be ready for a PR and my team and I can review this and let you know if there are any changes necessary before merging into main and including in the next release. Let me know if you would be interested in contributing this PR or if you have any questions. Thanks!
tom-rb
fivetran-avinash
Is there an existing feature request for this?
Describe the Feature
It's already possible to extend
netsuite2__transaction_detailswith the passthrough columns of accounts and departments, but not locations.So, the same way
accounts_pass_through_columnsanddepartments_pass_through_columnsare used in transaction details, I'd expectlocations_pass_through_columnsto do the same.Describe alternatives you've considered
As a workaround (which I don't think it's ideal), I've used
transaction_lines_pass_through_columnsto includelocation_idinnetsuite2__transaction_details, and then I perform the join again withstg_netsuite2__locationsto fetch the additional columns.Are you interested in contributing this feature?
Anything else?
I tested a trivial change to include
{{ fivetran_utils.persist_pass_through_columns('locations_pass_through_columns', identifier='locations') }}innetsuite2__transaction_detailsand I got my desired behavior, but I haven't run all tests of this package.