Open jmongerlyra opened 2 weeks ago
Hi @jmongerlyra thank you for opening this issue and the PR. I will take a closer look at this after the weekend!
Hello @jmongerlyra , thanks for doing all the work in separating out the initial PR!
I do have two requests before we bring this into a future sprint:
Sorry for all the extra leg work you have to do here, but it'll accelerate our development cycle if you provide these details. Let me know if you have any questions!
@fivetran-avinash I cherry picked the commits and closed the other PRs. Let me know if you have any questions or feedback.
Thanks @jmongerlyra ! We've kicked off work on #131 this sprint (as well as this issue related to your PR in the source) and our team will revisit this issue afterward.
Is there an existing issue for this?
Describe the issue
Issue 1 The account number for income statement and CTA accounts in the balance sheet model is currently set to NULL. This is not how it is presented on the native Balance Sheet report in NetSuite.
Income statement accounts should use the account number of the system-generated retained earnings account. CTA should use the account number of the system-generated CTA account.
Issue 2 Commonly used fields are missing from the balance sheet, income statement, and transaction details models. See list below.
_models/netsuite2/intermediate/base/int_netsuite2__transactionlines.sql
transaction_accounting_lines.exchange_rate
: Exchange rate used on the transaction_models/netsuite2/netsuite2__balancesheet.sql
subsidiaries.full_name
: Full hierarchical name of the subsidiary. Useful in sorting.accounts.display_name
: Account name without number or hierarchy. Cleaner than other name values.is_account_leftside
: Boolean indicating if account has a native debit balance. This is on other models but missing from balance sheet._models/netsuite2/netsuite2__transactiondetails.sql
transactions.is_reversal
: Boolean indicating line is reversaltransactions.reversal_transaction_id
: Transaction ID of the counterparty in a reversing pairtransactions.reversal_date
: Transaction Date of the counterparty in a reversing pairtransactions.is_reversal_defer
: Boolean indicating reversal deferraltransaction_lines.is_eliminate
: Boolean indicating line will auto-eliminatedepartments.full_name
: Full hierarchical name of the department. Useful for sorting.subsidiaries_currencies.symbol
: Currency of the subsidiarytransaction_lines.netamount
: Net amount of transaction line. This is the actual amount entered when it's in a currency other than the functional currency of the subsidiary.Issue 3 Would like to add
subsidiaries_pass_through_columns
so that fields from the subsidiary table can be added to the transaction details model.Relevant error log or model output
dbt Project configurations
Package versions
What database are you using dbt with?
snowflake
dbt Version
1.7.14
Additional Context
No response
Are you willing to open a PR to help address this issue?