fivetran / dbt_netsuite

Data models for Fivetran's Netsuite connector, built using dbt.
https://fivetran.github.io/dbt_netsuite/
Apache License 2.0
36 stars 34 forks source link

BUG - Balance sheet limited to 100 results #29

Closed bmayer99 closed 3 years ago

bmayer99 commented 3 years ago

Are you a current Fivetran customer? Benoit Mayer - Stedi

Describe the bug The balance sheet model does not produce full results I think the line below should be removed https://github.com/fivetran/dbt_netsuite/blob/13fddb854c2e4644c262b150622c831ebb216268/models/netsuite__balance_sheet.sql#L178

Package Version 0.3.1

Warehouse

- [ ] BigQuery - [ ] Redshift - [x] Snowflake - [ ] Postgres - [ ] Databricks - [ ] Other (provide details below) **Are you interested in contributing to this package?**
fivetran-joemarkiewicz commented 3 years ago

@bmayer99 you are indeed correct that the line you mentioned should be removed. That limit was a holdover from our testing of the release of the package and it has since been removed. I have pushed the change to master and cut a new v0.3.2 release of the netsuite package. I also ensured there are no other limits throughout the package.

This release should be live on the dbt hub most likely tomorrow morning. Thanks again for catching this issue and calling it out to our team.