fivetran / dbt_netsuite

Data models for Fivetran's Netsuite connector, built using dbt.
https://fivetran.github.io/dbt_netsuite/
Apache License 2.0
36 stars 34 forks source link

[Feature] Disable source tables in transaction_details model #45

Closed calder-holt closed 1 year ago

calder-holt commented 2 years ago

Is there an existing feature request for this?

Describe the Feature

Similar to the way you can disable features in the jira package it would be nice to be able to disable source and staging models that flow into the transaction details model if you are not using that functionality in netsuite. We are not using the vendorcategory or accountingbooksubsidiary sources so they do not flow through our Fivetran connector, and we cannot use the package. If we could disable the sources flowing into the model the same way you can here, we could use the models and test them out.

Describe alternatives you've considered

Rewriting our own transaction details model without the sources we do not use.

Are you interested in contributing this feature?

Anything else?

https://github.com/fivetran/dbt_jira_source#disabling-models

fivetran-jamie commented 2 years ago

hey @calder-holt working on this rn -- seems straightforward enough, but i'm curious about your use case, specifically around accountingbooksubsidiary. do y'all not use that functionality in Netsuite?

fivetran-jamie commented 2 years ago

also i've got a working branch if you'd like to try it out!

packages:
- git: https://github.com/fivetran/dbt_netsuite.git
  revision: feature/disable-vc-abs
  warn-unpinned: false
calder-holt commented 2 years ago

Thanks @fivetran-jamie! We actually encountered a handful of areas in the package that are features we don't use in Netsuite. We weren't using accountingbook, accountingbooksubsidiary, and vendorcategory because we don't use multi-book accounting.

fivetran-jamie commented 2 years ago

Ah i see -- does that mean you don't have an accountingbook source table either? Or any other source tables?

Also are vendor categories a multi-book accounting thing as well? Or just another Netsuite feature y'all don't use?

calder-holt commented 1 year ago

Correct we also don't have an accountingbook table. I believe we don't have the functionality for vendorcategory (the table does not sync)

fivetran-jamie commented 1 year ago

gotcha, so are you seeing errors around accountingbook models as well? i'm wondering if we can consolidate this all into a using_multibook_accounting variable that would disable all the necessary tables (hence my vendor category question)

calder-holt commented 1 year ago

I think that would be a good plan

fivetran-jamie commented 1 year ago

this fix is in v0.6.2! there's a netsuite2__multibook_accounting_enabled var and netsuite2__using_vendor_categories var that are both true by default