search

fivetran / dbt_netsuite

Data models for Fivetran's Netsuite connector, built using dbt.
https://fivetran.github.io/dbt_netsuite/
Apache License 2.0
36 stars 34 forks source link

Fix converted_amount in balance sheet #79

Closed jmongerlyra closed 11 months ago

jmongerlyra commented 12 months ago

Translation based on general_rate_type instead of account_category.

Please provide your name and company Jared Monger, Lyra Health

Link the issue/feature request which this PR is meant to address https://github.com/fivetran/dbt_netsuite/issues/75

Detail what changes this PR introduces and how this addresses the issue/feature request linked above. This change fixes a currency translation issue in the balance sheet table. In order to match the NetSuite balance sheet report, accounts should translate based on the general_rate_type rather than the account_category.

How did you validate the changes introduced within this PR? First, we materialized the balance sheet table with this change incorporated. Next, we summarized the results by account_type_name and reconciled to the NetSuite balance sheet report.

Which warehouse did you use to develop these changes? Snowflake

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Provide an emoji that best describes your current mood

:metal: **Feedback** Appreciate the collaboration from the Fivetran team.
jmongerlyra commented 11 months ago

Duplicated by https://github.com/fivetran/dbt_netsuite/pull/82