This PR will address the following Issue/Feature: #75
This PR will result in the following new package version: TBD (we are not releasing this version and will be folding it in with #78 once resolved)
LIkely not breaking as this will fix internal logic on one field but not add/remove any current fields.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Adjusted our translation rate logic to calculate converted_amount in netsuite__balance_sheet and netsuite2__balance_sheet.
The logic is adjusted so we examine the general_rate_type rather than account_category, as is intended by Netsuite definitions.
Historical and average rates now convert amounts into the converted_amount_using_transaction_accounting_period. Otherwise, it looks at converted_amount_using_reporting_month.
The is_leftside logic is added to make sure debit values are properly assigned as negative converted values if false and positive if true.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[NA] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[ ] The appropriate issue has been linked and tagged
[ ] You are assigned to the corresponding issue and this PR
[ ] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
Provided details to @fivetran-jamie privately.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[NA] README updates have been applied (if applicable)
[NA] DECISIONLOG updates have been updated (if applicable)
[NA] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: #75
This PR will result in the following new package version: TBD (we are not releasing this version and will be folding it in with #78 once resolved)
LIkely not breaking as this will fix internal logic on one field but not add/remove any current fields.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
converted_amount
innetsuite__balance_sheet
andnetsuite2__balance_sheet
.general_rate_type
rather thanaccount_category
, as is intended by Netsuite definitions.converted_amount_using_transaction_accounting_period
. Otherwise, it looks atconverted_amount_using_reporting_month
.is_leftside
logic is added to make sure debit values are properly assigned as negative converted values if false and positive if true.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Provided details to @fivetran-jamie privately.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
👓