Closed JessVagnoni closed 11 months ago
Hi there @JessVagnoni, thanks for taking the time to open this issue!
I agree that it would make way more sense to look at the account type IDs. I'd first like to confirm that the account type IDs are indeed standardized across different Netsuite environments
Are you using netsuite or netsuite2?
If Netsuite(1) can you confirm that your netsuite.accounts.type
and netsuite.accounts.type_sequence
fields map onto each other like this?
If Netsuite2, can you confirm that your netsuite2.accounttype.id
IDs match the rightside of this
(source)
Thank ya!
Hi Jamie,
We are using Netsuite2 and I can confirm our account type IDs look like the second example.
Thank you!
On Tue, Sep 12, 2023 at 4:12 PM Jamie Rodriguez @.***> wrote:
Hi there @JessVagnoni https://github.com/JessVagnoni, thanks for taking the time to open this issue!
I agree that it would make way more sense to look at the account type IDs. I'd first like to confirm that the account type IDs are indeed standardized across different Netsuite environments
Are you using netsuite or netsuite2?
If Netsuite(1) can you confirm that your netsuite.accounts.type and netsuite.accounts.type_sequence fields map onto each other like this? [image: image] https://user-images.githubusercontent.com/65564846/267449044-6b6b8031-2af8-435f-af34-d91fb7d6f706.png
If Netsuite2, can you confirm that your netsuite2.accounttype.id IDs match the rightside of this [image: image] https://user-images.githubusercontent.com/65564846/267447386-cc5fa263-5cf0-4274-8713-9cf7ddeca73a.png (source https://blog.prolecto.com/2013/09/10/netsuite-searchfilter-internal-account-type-codes/ )
Thank ya!
— Reply to this email directly, view it on GitHub https://github.com/fivetran/dbt_netsuite/issues/83#issuecomment-1716357623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQKCR272DUK2TJVOZAYZS5LX2C6ZLANCNFSM6AAAAAA4VBHVLE . You are receiving this because you were mentioned.Message ID: @.***>
Great! We'll definitely fold this in! Ideally we'd also apply this to the Netsuite(1) models, so I'm going to first investigate if the numerical account_type IDs are consistent across different NS1 environments. We'll roll this out to NS2 regardless though
Awesome thanks Jamie!
Is there a timeline for when this is expected to be completed? And will this change be for just the Income Statement, or will it also take effect for any other models using names for account types?
Thank you
On Thu, Sep 14, 2023 at 5:30 PM Jamie Rodriguez @.***> wrote:
Great! We'll definitely fold this in! Ideally we'd also apply this to the Netsuite(1) models, so I'm going to first investigate if the numerical account_type IDs are consistent across different NS1 environments. We'll roll this out to NS2 regardless though
— Reply to this email directly, view it on GitHub https://github.com/fivetran/dbt_netsuite/issues/83#issuecomment-1720177701, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQKCR233UR5OK7COKHRC5BDX2NZNJANCNFSM6AAAAAA4VBHVLE . You are receiving this because you were mentioned.Message ID: @.***>
Hi @JessVagnoni we will be adding this to our upcoming sprint (starting tomorrow). You can expect our team to work on incorporating these updates and share details as we work through them including sharing a WIP branch which you will be able to test to validate the changes work on your side.
We will also plan to make the same changes to the Balance Sheet model, unless there are any unforeseen issues during development. However, we will likely restrict this update to only apply to NS2 data models.
We are facing a similar issue and the int_netsuite2__tran_with_converted_amounts
model is marking many of our accounts as false for is_income_statement
and not categorizing our account types correctly because our account type names don't match the logic in the account_category column
We are using Netsuite2, Redshift
- package: fivetran/netsuite
version: [">=0.9.0", "<0.10.0"]
Our netsuite2.accounttype.id
also matched what you included in the posts above
The type_name values from our int_netsuite2__accounts
table are as follows:
So for example our account type labeled Cost of Revenue
is being marked as null in the int_netsuite__transactions_with_converted_amounts
model even though that is what we named our cost of goods sold account type. And operating expense
should be marked as expense but is not.
Will the fix you are currently working on also fix the issue we are seeing? Or should I open up a different issue?
Hi @JessVagnoni and @alexandra-plassaras thanks for the additional information! I am picking up this issue and aim to have a test branch ready for you to try in the next week or so.
Hi @JessVagnoni and @alexandra-plassaras I have created a test branch that you can try out. I have incorporated the changes in all the models I saw were affected, but I would also really appreciate your feedback. You can install the test branch using the below code in place of the normal dbt_netsuite installation code.
- git: https://github.com/fivetran/dbt_netsuite.git
revision: bug/account-type-id
warn-unpinned: false
Note, the models updated are:
Version 0.10.0, which incorporates these changes, is now live! Closing this issue, but please let us know if you have any additional feedback.
Update can be installed using the below:
packages:
- package: fivetran/netsuite
version: [">=0.10.0", "<0.11.0"]
Is there an existing issue for this?
Describe the issue
Sql script income_statement_sort_helper references account type name but it doesn't include account types renamed in Netsuite environments. In our instance, we have renamed our 'cost of goods sold' to 'cost of service' and the Income Statement model no longer picks up our accounts.
Relevant error log or model output
No response
Expected behavior
Instead of using account type name, we would expect the ID to be used instead so that any renamed account types are not excluded
dbt Project configurations
https://github.com/fivetran/dbt_netsuite/blob/main/dbt_project.yml
config-version: 2 name: 'netsuite' version: '0.9.0' require-dbt-version: [">=1.3.0", "<2.0.0"]
models: netsuite: +materialized: table +schema: netsuite netsuite: intermediate: +materialized: ephemeral netsuite2: intermediate: +materialized: ephemeral
vars: netsuite:
Netsuite staging models
Package versions
https://github.com/fivetran/dbt_netsuite/blob/main/packages.yml
packages:
What database are you using dbt with?
snowflake
dbt Version
% dbt --version Core:
latest: 1.6.2 - Update available!
Your version of dbt-core is out of date! You can find instructions for upgrading here: https://docs.getdbt.com/docs/installation
Plugins:
snowflake: 1.5.2 - Update available!
At least one plugin is out of date or incompatible with dbt-core. You can find instructions for upgrading here: https://docs.getdbt.com/docs/installation
Additional Context
Are you willing to open a PR to help address this issue?