This PR will result in the following new package version:
v0.10.0
Breaking change since are changing how records are categorized and some may be different than before (for example, if a prior issue was now corrected).
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Updated the following models to reference account_type_id instead of type_name:
int_netsuite2__tran_with_converted_amounts
netsuite2__balance_sheet
netsuite2__income_statement
netsuite2__transaction_details
This change was implemented because type_name was previously utilized to categorize records, which was causing issues for users that customized the type_name values. Utilizing the unique identifier account_type_id instead produces more accurate results in the final models.
Removed accepted_values test from column account_type_names in model netsuite2__transaction_details since logic is now based on account_type_id instead, and type names can be changed by the user.
Updated documents with descriptions for account_type_id
** ❗ Note - references to "prepaid" were removed since they became moot when moving to using ids.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[ ] ~dbt run –vars (if applicable)~
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
See internal ticket for validation.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[x] README updates have been applied (if applicable)
[ ] ~DECISIONLOG updates have been updated (if applicable)~
[x] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature:
83
This PR will result in the following new package version:
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
account_type_idinstead oftype_name:type_namewas previously utilized to categorize records, which was causing issues for users that customized thetype_namevalues. Utilizing the unique identifieraccount_type_idinstead produces more accurate results in the final models.accepted_valuestest from columnaccount_type_namesin modelnetsuite2__transaction_detailssince logic is now based onaccount_type_idinstead, and type names can be changed by the user.account_type_id** ❗ Note - references to "prepaid" were removed since they became moot when moving to using ids.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
See internal ticket for validation.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🆔