fivetran / dbt_netsuite

Data models for Fivetran's Netsuite connector, built using dbt.
https://fivetran.github.io/dbt_netsuite/
Apache License 2.0
36 stars 34 forks source link

[Feature] Update `intercompany` categorization #87

Closed fivetran-catfritz closed 10 months ago

fivetran-catfritz commented 11 months ago

Is there an existing feature request for this?

Describe the Feature

Currently, netsuite2__transaction_details considers an account as intercompany if the account name contains the word “intercompany”. Reviewing the netsuite documentation (see here and here) and per internal discussion, we should be using the eliminate column from the source account table.

We will need to:

  1. Bring in eliminate column to stg_netsuite2__accounts (also should check on netsuite if this applies)
  2. Use eliminate to determine is_account_intercompany flag. The source uses the letters T and F (well our source does, so maybe consider if it can also come in as boolean), so convert to boolean in transform.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

Anything else?

No response

jmongerlyra commented 11 months ago

I agree with this approach.

jmongerlyra commented 11 months ago

What's the timeline on this fix? It is actually needed in our environment for all three models.

fivetran-joemarkiewicz commented 11 months ago

@jmongerlyra we will plan to include this update in the next major release of netsuite. We are waiting to validate the results with our internal finance team before rolling them out.

I expect by the end of our current sprint (10/18) we are hoping to have all updates rolled out to the next version of the Netsuite package.

fivetran-joemarkiewicz commented 10 months ago

This feature has been incorporated in the latest release of the dbt_netsuite and dbt_netsuite_source packages. These updates should be live at the top of the hour.