search

fivetran / dbt_netsuite

Data models for Fivetran's Netsuite connector, built using dbt.
https://fivetran.github.io/dbt_netsuite/
Apache License 2.0
36 stars 34 forks source link

Add accounting_book_name #97

Closed jmongerlyra closed 10 months ago

jmongerlyra commented 10 months ago

Please provide your name and company Jared Monger, Lyra Health

Link the issue/feature request which this PR is meant to address https://github.com/fivetran/dbt_netsuite/issues/89

Detail what changes this PR introduces and how this addresses the issue/feature request linked above. Adds accounting_book_name to models.

How did you validate the changes introduced within this PR? Lyra forked the repo and implemented/validated the changes against NetSuite reporting.

Which warehouse did you use to develop these changes? Snowflake

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Provide an emoji that best describes your current mood

**Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)
jmongerlyra commented 10 months ago

@fivetran-catfritz @fivetran-joemarkiewicz I added accounting_book_name into the models since users are more familiar with the book names than internal IDs.