search

fivetran / dbt_netsuite_source

Data models for Fivetran's Netsuite source package, built using dbt.
https://fivetran.github.io/dbt_netsuite_source/
Apache License 2.0
14 stars 20 forks source link

add pass through for customers #10

Closed Yaruis19 closed 2 years ago

Yaruis19 commented 2 years ago

Are you a current Fivetran customer?

Yes What change(s) does this PR introduce?

Add pass-through columns variables for NetSuite customers Does this PR introduce a breaking change?

How did you test the PR changes?

- [ ] CircleCi - [x] Other (please provide additional testing details below) I tested by adding the local repo as my dbt package and ran `dbt run -m netsuite_source` to make sure the new columns I added locally did pass through **Select which warehouse(s) were used to test the PR** - [ ] BigQuery - [ ] Redshift - [x] Snowflake - [ ] Postgres - [ ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** :dancer: **Feedback** I would love this package can add variables for all models We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 2 years ago

Thanks so much for opening this PR @Yaruis19! ❤️ 🎉

At first glance your changes make sense and look good. I will take a deeper dive and let you know if I have any further questions before approving and merging to be included in the next release.

Yaruis19 commented 2 years ago

Thanks so much for opening this PR @Yaruis19! ❤️ 🎉

At first glance your changes make sense and look good. I will take a deeper dive and let you know if I have any further questions before approving and merging to be included in the next release.

Thank you! @fivetran-joemarkiewicz Do you have an idea about when we will do the next release? I have some pending model that replies to this being added. If it's going to be more than several weeks from now, I will do some workaround from my side in the meantime.

fivetran-joemarkiewicz commented 2 years ago

@Yaruis19 I actually have some time available today and can do a more thorough review. Realistically, I will be able to cut a new release of the dbt_netsuite_source package by Monday.

With that, I do have one quick question. Are you intending that these customer passthrough columns be used in any downstream models within the dbt_netsuite package? Or would you use these passthrough columns for your own modeling efforts?

Yaruis19 commented 2 years ago

dbt_netsuite

@fivetran-joemarkiewicz This customer passthrough are added for my own modeling efforts. I haven't gotten a chance to use the standard model since our NetSuite is configured a little differently. If you want, I'm happy to add pass through to rest of the models if needed, since I already have this PR open :)

fivetran-joemarkiewicz commented 2 years ago

@Yaruis19 sounds good! Since there haven't been any other requests for passthroughs with the other models I think it would be fine to just stick with customers for the time being. Then we can create other PRs if necessary as I would like to keep the number of variables to a minimum if possible.

I'll review today though and let you know. Thanks!

Yaruis19 commented 2 years ago

Thank you! @fivetran-joemarkiewicz