search

fivetran / dbt_netsuite_source

Data models for Fivetran's Netsuite source package, built using dbt.
https://fivetran.github.io/dbt_netsuite_source/
Apache License 2.0
14 stars 20 forks source link

Magic bot 36c3c8115b #13

Closed phillem15 closed 2 years ago

phillem15 commented 2 years ago

Are you a current Fivetran customer?

Evan Phillips, Lead BI Architect, Nordic Global

What change(s) does this PR introduce?

Adding pass through columns for Subsidiaries and Consolidated Exchange Rates staging models.

Does this PR introduce a breaking change?

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [ ] CircleCi - [x ] Other (please provide additional testing details below) Followed the suggested approach in [this post](https://discourse.getdbt.com/t/contributing-to-an-external-dbt-package/657), forked and cloned the repository to my local machine, changed the code and made sure my project ran with the updated code! **Select which warehouse(s) were used to test the PR** - [ ] BigQuery - [ ] Redshift - [ ] Snowflake - [ ] Postgres - [x ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** :sunglasses: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
phillem15 commented 2 years ago

Hi @fivetran-joemarkiewicz thanks for reaching out! I've made the changes you've requested (hoping I've done them correctly).

As for your first question, I am only looking to leverage these fields in the staging models of my own project.

fivetran-joemarkiewicz commented 2 years ago

Thanks so much for the clarification @phillem15! I will plan to give your changes a final review and possibly merge later this week 😄

I will let you know if I have any other questions!

phillem15 commented 2 years ago

Hi @fivetran-joemarkiewicz I realized the tests I conducted were not looking at my official changes. I have retested and made some final adjustments to the models. I have re-run the tests and everything is now looking good on my end. Thanks!