@fivetran-jamie this PR acts as my review of your original PR #17. Please give the following a thorough review yourself and let me know if you have any questions. A few major items to call out within this PR regarding changes I have made:
Added all yml and README documentation
Added identifier variables for both netsuite and netsuite2 sources
Changed the data_model variable to be netsuite_data_model to make it a bit more descriptive
Renamed variables to be more descriptive if it is for the netsuite or netsuite2 source
Generated all seed data for netsuite2 source and renamed seed data to fit the netsuite and netsuite2 naming convention
Added a netsuite2_variable_name variable that is to only be used for integration tests. This way when CircleCi runs, it will run on both netsuite and netsuite2 sources. It also makes sure the entire docs for both sources are generated.
Updated CHANGELOG
A few places I would like you to take a close eye and make sure my updates are appropriate:
[x] The entire README
Especially the needed tables from Netsuite for netsuite2
[x] The CHANGELOG entry
[ ] The variable name changes I applied. Especially if the netsuite2_variable_name variable makes sense and is appropriate.
@fivetran-jamie this PR acts as my review of your original PR #17. Please give the following a thorough review yourself and let me know if you have any questions. A few major items to call out within this PR regarding changes I have made:
data_modelvariable to benetsuite_data_modelto make it a bit more descriptivenetsuite2_variable_namevariable that is to only be used for integration tests. This way when CircleCi runs, it will run on both netsuite and netsuite2 sources. It also makes sure the entire docs for both sources are generated.A few places I would like you to take a close eye and make sure my updates are appropriate:
netsuite2_variable_namevariable makes sense and is appropriate.