fivetran / dbt_netsuite_source

Data models for Fivetran's Netsuite source package, built using dbt.
https://fivetran.github.io/dbt_netsuite_source/
Apache License 2.0
14 stars 20 forks source link

disable vendor_categories and multibook accounting tables #21

Closed fivetran-jamie closed 2 years ago

fivetran-jamie commented 2 years ago

Are you a current Fivetran customer?

Fivetran made PR

What change(s) does this PR introduce?

Adds variables to disable sources and models associated with vendor_categories and accounting_book_subsidiaries

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

🐀 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-jamie commented 2 years ago
  • [ ] Should the configs be added to the get column macros for get_accounting_books_columms, get_accountbooksubsidiaries_columns and get_vendorcategory_columns?

nah i don't think the macros need to be configured at all -- the macros are called within the models that themselves have configs (so if a model doesn't run, the macro won't be called)