search

fivetran / dbt_netsuite_source

Data models for Fivetran's Netsuite source package, built using dbt.
https://fivetran.github.io/dbt_netsuite_source/
Apache License 2.0
14 stars 20 forks source link

add pass through for vendors and items #23

Closed rpalloni closed 1 year ago

rpalloni commented 1 year ago

Are you a current Fivetran customer? Yes

What change(s) does this PR introduce? It allows to extend the fields in stg models as regards vendors and items

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood :dancer:

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

rpalloni commented 1 year ago

Ok cool! Found a temporary fix in the meanwhile so I think I'll wait for the large scale migration. Any idea on when it will be? Thanks anyway

fivetran-joemarkiewicz commented 1 year ago

Awesome! Next week our team will be at the Coalesce Conference and we will plan to make a team wide effort to roll these out the following week. However, this large scale release is all dependent on when dbt-utils v1.0.0 officially releases.

ghost commented 1 year ago

Hi @fivetran-joemarkiewicz , any news on this? Seems like dbt-utils v1.0.0 is up since two weeks but old version is still there image

Thanks

fivetran-joemarkiewicz commented 1 year ago

Hey @ropalloni apologies for the late reply as I am just getting back from the holiday PTO.

Thanks for asking about this, and we will be releasing these updates this week! You should see all our packages updates before the end of the week. Thanks!

ghost commented 1 year ago

Ok now it works. However you did not align netsuite2 with the same fix....

fivetran-joemarkiewicz commented 1 year ago

Hi @ropalloni thanks for raising this to me. You are correct that we missed in this PR to persist the items and vendors passthrough columns to the netsuite2 models.

We can account for this in the next release of the netsuite package. Is this currently a blocker for you?

ghost commented 1 year ago

When will be next release?

fivetran-joemarkiewicz commented 1 year ago

There is no slated release of the netsuite_source package, but we could realistically work to fold this into either this week or next week.

ghost commented 1 year ago

This week or next week would be perfect! Btw it's just adding the same macro in those models. Let me know.

fivetran-joemarkiewicz commented 1 year ago

Sounds great! Yeah this should be a pretty simple update, but want to be realistic with the other changes (across our other packages) that are taking place in our current sprint. I just created a new issue (above) for us to be able to track this bug fix.

I also marked it as a good first issue in case others come across and want to contribute to the package before my team is able to get to it.

ghost commented 1 year ago

Hi @fivetran-joemarkiewicz ! Do you have any updates on this? Thanks

fivetran-joemarkiewicz commented 1 year ago

Hey @ropalloni the issue I linked above to include the passthrough columns is currently in progress. I would reference Issue #25 and the corresponding PR #27 for the progress on this addition.