fivetran / dbt_netsuite_source

Data models for Fivetran's Netsuite source package, built using dbt.
https://fivetran.github.io/dbt_netsuite_source/
Apache License 2.0
14 stars 20 forks source link

[Feature] Add disable exchange rate variable #35

Closed fivetran-avinash closed 1 year ago

fivetran-avinash commented 1 year ago

PR Overview

This PR will address the following Issue/Feature: Issues from transform package https://github.com/fivetran/dbt_netsuite/issues/70

This PR will result in the following new package version: 0.4.0

**Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:** Introduces variable `netsuite2__using_exchange_rate` to allow users who don't utilize exchange rates in Netsuite2 the ability to disable that functionality. ## PR Checklist ### Basic Validation Please acknowledge that you have successfully performed the following commands locally: - [x] dbt compile - [x] dbt run –full-refresh - [x] dbt run - [x] dbt test - [x] dbt run –vars (if applicable) Before marking this PR as "ready for review" the following have been applied: - [x] The appropriate issue has been linked and tagged - [x] You are assigned to the corresponding issue and this PR - [x] BuildKite integration tests are passing ### Detailed Validation Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review": - [x] You have validated these changes and assure this PR will address the respective Issue/Feature. - [x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages. - [x] You have provided details below around the validation steps performed to gain confidence in these changes.

Models run successfully whether vars are configure to true or false.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

💱