Bugfix/consolidate exch accounting book

[fivetran-reneeli]

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_netsuite/issues/72

This PR will result in the following new package version: v0.7.0

Non breaking as these changes are happening under the hood and will not impact downstream fields that customers see.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR: Brought in accounting_book_id (accountingbook) to the stg_netsuite2__consolidated_exchange_rates model.

Details: This is responding to a customer issue seeing duplicate records were showing in end models transaction_details (and potentially balance_sheet too...).

The int_netsuite2__consolidated_exchange_rates model was the root cause for duplicates because the join:

    from consolidated_exchange_rates
    left join accounting_book_subsidiaries
        on consolidated_exchange_rates.to_subsidiary_id = accounting_book_subsidiaries.subsidiary_id

was resulting in multiple accounting_book_id 's. We should add accounting_book_id to the join. But --

We can remove int_netsuite2__consolidated_exchange_rates entirely now since that was to bring accounting_book_id in, and now we have that via the consolidated_exchange_rates staging model.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• [x] dbt compile
• [x] dbt run –full-refresh
• [x] dbt run
• [x] dbt test
• [n/a] dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• [x] The appropriate issue has been linked and tagged
• [x] You are assigned to the corresponding issue and this PR
• [ ] BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• [x] You have validated these changes and assure this PR will address the respective Issue/Feature.
• [x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• [x] You have provided details below around the validation steps performed to gain confidence in these changes.

  Validating with customer that duplicate records are removed/ tests are passing

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • [x] indexed within dbt_project.yml
  • [x] indexed within integration_tests/dbt_project.yml
• [x] CHANGELOG has individual entries for each respective change in this PR
• [ ] README updates have been applied (if applicable)
• [ ] DECISIONLOG updates have been updated (if applicable)
• [ ] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• [ ] docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

:dancer:

[fivetran-reneeli]

regen docs after approve

[fivetran-reneeli]

Your changes look mostly good, I just had a suggestion to make some small changes in the CHANGELOG which look to be artifacts of the merge conflicts.

Additionally, I wanted to do a quick test to run this package version with the current live version of the dbt_netsuite package to make sure this field addition wouldn't cause any failures.... and surprisingly it does!

This is because in the downstream intermediate model when we reference the accounting_book_id we do not specify the source table and therefore we get this ambiguous column error 😱. Therefore, we cannot make this be a patch upgrade. Instead we will want to make this a breaking change as well.

Can you make the appropriate breaking change version bump updates (don't forget to update the README version as well) and then let me know once those are applied for re-review.

@fivetran-joemarkiewicz Ahh.. Thanks for noticing that, definitely needs to be a breaking change then. Updated the versions, readme, and made a note in the changelog. I'll make the downstream updates as well.