Feature/subsidiary currency - Githubissues

fivetran / dbt_netsuite_source

Data models for Fivetran's Netsuite source package, built using dbt.

https://fivetran.github.io/dbt_netsuite_source/

Apache License 2.0

14 stars 20 forks source link

Feature/subsidiary currency #42

Closed fivetran-catfritz closed 8 months ago

fivetran-catfritz commented 10 months ago

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_netsuite/issues/94

This PR will result in the following new package version:

v0.9.0

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨:

Addition of the currency field within the stg_netsuite2__subsidiaries model.
- This addition likely won't be breaking for a large number of users. However, if you are leveraging the subsidiaries_pass_through_columns variable and have included currency as a pass through column, you will experience a duplicate column error. We advise you remove the currency field as a pass through columns to avoid runtime errors following this upgrade.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

[x] dbt run –full-refresh && dbt test
[ ] ~dbt run (if incremental models are present)~

Before marking this PR as "ready for review" the following have been applied:

[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[x] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[x] Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Column added used in related transform PR.