search

fivetran / dbt_netsuite_source

Data models for Fivetran's Netsuite source package, built using dbt.
https://fivetran.github.io/dbt_netsuite_source/
Apache License 2.0
14 stars 20 forks source link

Feature #50: Enable teams to configure additional columns for staging entities models #51

Closed FrankTub closed 1 month ago

FrankTub commented 1 month ago

Please provide your name and company

Frank Tubbing - Beequip

Link the issue/feature request which this PR is meant to address

https://github.com/fivetran/dbt_netsuite_source/issues/50

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.

Enables me to define custom entity fields without having to create my own base/staging model.

How did you validate the changes introduced within this PR?

Ran my forked repo branch in my own dbt project

Which warehouse did you use to develop these changes?

Postgres

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)
FrankTub commented 1 month ago

Not really sure if I should bump the version here ?

fivetran-avinash commented 1 month ago

Not really sure if I should bump the version here ?

Hi @FrankTub ! Yes, you'll want to bump the version up. Since I don't think any customers would be impacted, I'd recommend a minor update up to version 0.10.1. (I can also commit those changes directly as well, see the below comment)

fivetran-avinash commented 1 month ago

Thanks for opening this PR @FrankTub ! I think this mostly looks good--I've tested these changes and I feel mostly confident this is the correct configuration. There is one significant change I noticed, but otherwise we are close to releasing this change.

I was wondering if you had any issue with me making some commits directly to your branch? There are a few changes within our integration_tests folder and other general maintenance changes we include for every release of dbt_netsuite.

If it works for you, as I review your changes I can make these background changes to your branch. This way we may fold them into the main branch more smoothly for a release early next week.

If not, I can provide you with the required changes as well in my PR review.

Once you give me the approval either way, we can kickstart the process of this release! Let me know your questions and concerns.

fivetran-avinash commented 1 month ago

@FrankTub Also one additional question: Is group one of the columns you are attempting to passthrough? There are some intricacies we will need to address on our end that we will add to the release if that's the case, as group is a reserved keyword and our current passthrough column logic isn't quite equipped to handle this. But we have workarounds in that case.

FrankTub commented 1 month ago

@fivetran-avinash , the field group is not per se one of the fields we will need to pass through.

You are free to add commits to my branch without breaking any functionality at our side. We want to start using this, but don't use it yet in our production environment. I've bumped the version in my branch to 0.10.1.