search

fivetran / dbt_netsuite_source

Data models for Fivetran's Netsuite source package, built using dbt.
https://fivetran.github.io/dbt_netsuite_source/
Apache License 2.0
14 stars 20 forks source link

FEATURE - Add Passthrough Columns to Locations Model #9

Closed oreoana closed 2 years ago

oreoana commented 2 years ago

Are you a Fivetran customer? Yes -- Blue Bottle Coffee

Is your feature request related to a problem? Please describe. I'd like to be able to add pass-through columns to some of the Netsuite staging models, specifically stg_netsuite__locations.

Describe the solution you'd like Be able to specify pass-through columns for the locations staging model in the netsuite_source package using the existing approach here: https://github.com/fivetran/dbt_netsuite_source#configuration

Describe alternatives you've considered Build our own Netsuite locations staging model.

Please indicate the level of urgency and business impact of this request Medium -- would allow us to set up a better infrastructure for our locations data pipeline.

Are you interested in contributing to this package?

fivetran-joemarkiewicz commented 2 years ago

Hi @oreoana

Thanks so much for opening this feature request! I have added this feature request to our backlog and we will let you know back here once we are able to assign this request to a future sprint.

However, in the meantime as this is a relatively easy addition to the package (and I see you are open to contributing) then I would highly recommend opening a PR against the master branch for this addition. You can follow the same process of this variable as shown in stg_netsuite__accounts model and name the variable in line with the other ones. I am thinking locations_pass_through_columns. Let me know if you have any questions, otherwise we will let you know here once we are able to tackle this request in a future sprint.

Thank you!

fivetran-joemarkiewicz commented 2 years ago

@oreoana I actually am working on a similar PR #10 where the pass through columns for customers is being added. I will build off this PR and add the locations variable as well.

fivetran-joemarkiewicz commented 2 years ago

@oreoana I wanted to provide an FYI that the locations_pass_through_columns variable was included in the latest release of the dbt_netsuuite_source package. You can expect the package to be live on the dbt hub at the top of the hour.

Thanks again for opening this issue! 😄

oreoana commented 2 years ago

@fivetran-joemarkiewicz great! Thanks so much for this!