fivetran-jamie
commented
3 years ago hey @payzer-mike - thanks for making this!!
alas i did not see this PR before realizing my mistake and adding the same/very very similar fix on my own branch. i'll merge to main and release shortly, if you'd like to confirm my fix works for ya. gonna close this PR since i've already made my conflicting edits, but many thanks for contributing 🙂
Explicitly added an uppercase identifier for source “group”.
Are you a current Fivetran customer? Yes.
What change(s) does this PR introduce?
Solves the SQL error when creating a table named “group” (a reserved keyword) on the Snowflake platform. @fivetran-jamie had already added the conditional quoting. This adds an uppercase identifier to the model, which completes the solution. The identifier needed to be added, so it could be quoted. The identifier needed to be uppercase, to match the Fivetran Pendo schema, since the quotes make the table name case-sensitive.
Does this PR introduce a breaking change?
Fixes a known issue with Snowflake.
Is this PR in response to a previously created Issue
How did you test the PR changes?
- [ ] CircleCi - [x] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [ ] BigQuery - [ ] Redshift - [x] Snowflake - [ ] Postgres - [ ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** :surfer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you’d like to see next.