fivetran / dbt_pinterest

Fivetran data transformations for Pinterest Ads built using dbt.
https://fivetran.github.io/dbt_pinterest/
Apache License 2.0
3 stars 7 forks source link

Feature/advertiser addition #19

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR adds the advertiser_history model into the ad_adapter final. This allows for the advertiser name to be carried through. This advertiser_name will then be used to provide the account_name to the final roll up report in the ad_reporting package.

Does this PR introduce a breaking change?

This should not be a breaking change. 96% of Fivetran Pinterest customers have the advertiser_history model. As such, it would be safe to keep this as a patch upgrade.

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [X] CircleCi - [x] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [X] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** 🩹 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 2 years ago

@fivetran-sheringuyen your above comment got me thinking some more...

Before merging this I want to 100% confirm that Advertisers share the same functionality as Accounts in the other ad platforms. With the data we have tested this seems to be the case. However, I want to confirm this is before we move forward with this PR.

fivetran-joemarkiewicz commented 2 years ago

This will be integrated into PR #21