This PR will address the following Issue/Feature:
Internal ticket, to add conversions data
This PR will result in the following new package version:
0.11.0
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Feature update
We have added the following fields to each pinterest_ads end model:
total_conversions
total_conversions_quantity
total_conversions_value_in_micro_dollar
In the event that you were already passing the above fields in via our passthrough columns, the package will dynamically avoid "duplicate column" errors.
The above new field additions are 🚨 breaking changes 🚨 for users who were not already bringing in conversion fields via passthrough columns.
Added more information about the difference in grains and their relationships in the DECISIONLOG.
Under the hood
Created pinterest_ads_persist_pass_through_columns macro to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.
Added integrity and consistency validation tests within integration_tests folder for the transformation models (to be used by maintainers only).
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[na] dbt run –full-refresh
[x] dbt run
[x] dbt test
[x] dbt run –vars (if applicable). -- to test backwards compatibility, see internal note
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
Backwards compat: tested as noted in internal ticket:
PR Overview
This PR will address the following Issue/Feature: Internal ticket, to add conversions data
This PR will result in the following new package version:
0.11.0
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Feature update
pinterest_ads
end model:total_conversions
total_conversions_quantity
total_conversions_value_in_micro_dollar
Under the hood
pinterest_ads_persist_pass_through_columns
macro to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.integration_tests
folder for the transformation models (to be used by maintainers only).PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
horizontal_sum_conversions
vertical_sum_conversions
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
:dancer: