fivetran / dbt_pinterest

Fivetran data transformations for Pinterest Ads built using dbt.
https://fivetran.github.io/dbt_pinterest/
Apache License 2.0
3 stars 7 forks source link

Add conversions #34

Closed fivetran-reneeli closed 1 week ago

fivetran-reneeli commented 2 months ago

PR Overview

This PR will address the following Issue/Feature: Internal ticket, to add conversions data

This PR will result in the following new package version:

0.11.0

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Feature update

The above new field additions are 🚨 breaking changes 🚨 for users who were not already bringing in conversion fields via passthrough columns.

Under the hood

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  1. Backwards compat: tested as noted in internal ticket:

pinterest__ad_group_report_passthrough_metrics:

  • name: "total_conversions"
  • name: "total_view_checkout" alias: "t_view_checkout"
  1. Prior metrics are not affected: see consistency tests
  2. Conversion values aggregate correctly across grains that rollup: see horizontal integrity test horizontal_sum_conversions
  3. Conversion values aggregate correctly from staging to final models: see vertical integrity test vertical_sum_conversions

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

:dancer: