fivetran / dbt_qualtrics_source

Fivetran's Qualtrics Source dbt package
https://fivetran.github.io/dbt_qualtrics_source/
Apache License 2.0
2 stars 2 forks source link

bugfix/timestamp-without-time-zone #5

Closed fivetran-joemarkiewicz closed 7 months ago

fivetran-joemarkiewicz commented 7 months ago

PR Overview

This PR will address the following Issue/Feature: Internally raised Issue

This PR will result in the following new package version: v0.2.0

This likely won't be breaking for the majority of users. However, this will be changing the datatypes of a number of fields to timestamp without time zone; whereas, before they were timestamp with time zone. Therefore, we will mark this as breaking.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes: Bug Fixes 🚨

Please note: this update will likely only impact Redshift destinations as it was found the connector synced these fields as timestamp with time zone when in fact they were without. Most users will not see any changes following this release. But we marked this as breaking to ensure no possible datatype conflicts downstream.

Under the Hood

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please share any and all of your validation steps:

None of these changes really need any validating in the source package, so the core of the validation is done in combination with the downstream dbt_qualtrics package.

First I recreated the issue by setting up a new Qualtrics connector (for Redshift) and attempted to use the production version of the package. Alas, I saw the same error as documented: image

I then installed the local version of the qualtrics package with these changes included and saw the errors resolved! image

If you had to summarize this PR in an emoji, which would it be?

⏲️