fivetran / dbt_qualtrics_source

Fivetran's Qualtrics Source dbt package
https://fivetran.github.io/dbt_qualtrics_source/
Apache License 2.0
2 stars 2 forks source link

Distribution contact test #8

Closed dmcmtntp closed 3 weeks ago

dmcmtntp commented 1 month ago

Please provide your name and company Devin McManus, TNTP

Link the issue/feature request which this PR is meant to address

https://github.com/fivetran/dbt_qualtrics_source/issues/7

Detail what changes this PR introduces and how this addresses the issue/feature request linked above. adds contact_lookup_id to the distribution_contact unique test here: https://github.com/fivetran/dbt_qualtrics_source/blob/36dfc658cee91975d66e38f33c6ad8dc6fecba1b/models/stg_qualtrics.yml#L562-L566

How did you validate the changes introduced within this PR?

Ran test in TNTP development environment

Which warehouse did you use to develop these changes?

TNTP snowflake instance

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Provide an emoji that best describes your current mood

🤷‍♂️ **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)
fivetran-reneeli commented 1 month ago

Thanks @dmcmtntp for opening this as well as providing the underlying versioning and changelog updates ! We'll wrap this into an upcoming sprint and get it released!

dmcmtntp commented 4 weeks ago

changes committed!

fivetran-avinash commented 3 weeks ago

Thanks for that @dmcmtntp ! I have merged your changes into our branch and am hoping that we will be able to release these changes sometime later this week! We will keep you in the loop.

dmcmtntp commented 3 weeks ago

great, thank you!