fivetran / dbt_quickbooks

Fivetran data models for QuickBooks using dbt.
https://fivetran.github.io/dbt_quickbooks/
Apache License 2.0
26 stars 38 forks source link

[Bug] Balance Sheet Transactions Duplicating #43

Closed aufdenkamp closed 1 year ago

aufdenkamp commented 2 years ago

Is there an existing issue for this?

Describe the issue

We are experiencing duplicate general ledger entries in our balance sheet, causing it to not match our Quickbooks reporting.

What I'm seeing is that for each duplicate, there is one coming from each Transaction_Source of journal_entry and transfer. It also appears that the duplicate entries have a different Transaction_Index (one has an index of 0, the other an index of 1). There is only one duplicate of each duplicated transaction.

Relevant error log or model output

![image](https://user-images.githubusercontent.com/97621944/186465582-bc3784c7-4b15-4467-9b59-5319f7bf5142.png)

Expected behavior

I would expect only one value per transaction - either from transfer or journal entry.

dbt Project configurations

quickbooks:

Variables if your company utilizes the below parent and child transactional tables.

using_address:        True
using_bill:           True
using_credit_memo:    True
using_department:     True
using_deposit:        True
using_estimate:       True
using_invoice:        True
using_invoice_bundle: True
using_journal_entry:  True
using_payment:        True
using_refund_receipt: False
using_transfer:       True
using_vendor_credit:  True
using_sales_receipt:  False
using_purchase_order: False

Package versions

0.5.0, also tested the subindices fix prior to release

What database are you using dbt with?

snowflake

dbt Version

1.0

Additional Context

No response

Are you willing to open a PR to help address this issue?

aufdenkamp commented 2 years ago

image

aufdenkamp commented 2 years ago

I looked into this a little bit more - this is related to deleted transactions in Quickbooks. For example, in our Quickbooks instance, all of the transfer items in the above image are "deleted", but they are still coming through in the data, even after a historical resync.

fivetran-joemarkiewicz commented 2 years ago

Thanks for sharing this information @aufdenkamp!

Is there a way in the source data you are able to determine that these transactions are deleted? Or are you only able to determine as such after viewing direction in QuickBooks?

aufdenkamp commented 2 years ago

I have only been able to determine that they are deleted after viewing Quickbooks. I could not find any indication in the source data that they were deleted.

fivetran-joemarkiewicz commented 2 years ago

Thanks for sharing @aufdenkamp, let me do some digging to see if I can find a way to determine this in the source data. 🤔

aufdenkamp commented 2 years ago

@fivetran-joemarkiewicz Any luck?

fivetran-joemarkiewicz commented 2 years ago

Non yet 😢. I would recommend opening a ticket with our Support Team so our engineering team can take a closer look and hopefully find a way to understand if a transaction is deleted.

I'll keep looking in the meantime.

fivetran-joemarkiewicz commented 1 year ago

Hi @aufdenkamp just wanted to check in if you were able to reach out to customer support?

aufdenkamp commented 1 year ago

I have reached out - sounds like the issue in the Transfers table will be resolved today? Still working with support on some additional items.

On Mon, Sep 26, 2022 at 9:22 AM Joe Markiewicz @.***> wrote:

Hi @aufdenkamp https://github.com/aufdenkamp just wanted to check in if you were able to reach out to customer support?

— Reply to this email directly, view it on GitHub https://github.com/fivetran/dbt_quickbooks/issues/43#issuecomment-1258117413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXIZPOAE6OQ67P44UX3SQETWAGWSTANCNFSM57QALT4Q . You are receiving this because you were mentioned.Message ID: @.***>

fivetran-joemarkiewicz commented 1 year ago

Hi @aufdenkamp came back across this ticket and assume that everything is resolved on your end. Closing out this GitHub issue.

Feel free to reopen the issue if you feel there is more to discuss on this original issue. 😄