search

fivetran / dbt_recurly

Fivetran data transformations for Recurly built using dbt.
https://fivetran.github.io/dbt_recurly/
Apache License 2.0
4 stars 2 forks source link

[BUG] Date_day should be date_week #13

Closed fivetran-reneeli closed 1 year ago

fivetran-reneeli commented 1 year ago

https://github.com/fivetran/dbt_recurly/blob/2da1316991d1498e85317150d2587c74ea358972/models/intermediate/int_recurly__account_rolling_totals.sql#L36

While looking through this I just realized I think this coalesce should be using date_week, not date_day!

fivetran-joemarkiewicz commented 1 year ago

@fivetran-catfritz is this issue able to be closed out? It seems the previous PR addressed the original issue.

fivetran-catfritz commented 1 year ago

@fivetran-joemarkiewicz Sorry about that. Yes #15 addresses this issue, so closing this out.