This PR will address the following Issue/Feature: Issue #16
This PR will result in the following new package version:v0.2.2
Marked as nonbreaking as this shouldn't break current models, but help those with the current coalesce issue successfully run the models.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
The variables sage_intacct__using_bills and sage_intacct__using_invoices are used in coalesce statements. In the case where 1 is true and the other is false, the sage_intacct__ap_ar_enhanced fails for some warehouses. This is because in some warehouses like Snowflake, the coalesce clause is unable to only take 1 argument. Therefore, as a fix, this PR explicitly adds a null as a third argument. That way, for this scenario, there will still be 2 arguments.
In addition, I've added the aforementioned variable scenario to integration testing
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[X] dbt compile
[X] dbt run –full-refresh
[X] dbt run
[X] dbt test
[n/a] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[X] The appropriate issue has been linked and tagged
[X] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[X] You have validated these changes and assure this PR will address the respective Issue/Feature.
[X] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[X] You have provided details below around the validation steps performed to gain confidence in these changes.
After running the models I now see currency_code as an added field.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[X] indexed within dbt_project.yml
[X] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[n/a] README updates have been applied (if applicable)
[n/a] DECISIONLOG updates have been updated (if applicable)
[] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[X] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: Issue #16
This PR will result in the following new package version:
v0.2.2Marked as nonbreaking as this shouldn't break current models, but help those with the current coalesce issue successfully run the models.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
The variables
sage_intacct__using_billsandsage_intacct__using_invoicesare used in coalesce statements. In the case where 1 is true and the other is false, thesage_intacct__ap_ar_enhancedfails for some warehouses. This is because in some warehouses like Snowflake, the coalesce clause is unable to only take 1 argument. Therefore, as a fix, this PR explicitly adds a null as a third argument. That way, for this scenario, there will still be 2 arguments.In addition, I've added the aforementioned variable scenario to integration testing
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
After running the models I now see
currency_codeas an added field.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🤑