fivetran / dbt_salesforce_formula_utils

Package containing dbt macros to help generate salesforce formula fields synced from Fivetran.
https://fivetran.github.io/dbt_salesforce_formula_utils/
Apache License 2.0
16 stars 18 forks source link

fields to include allow for more than one argument #28

Closed fivetran-joemarkiewicz closed 2 years ago

fivetran-joemarkiewicz commented 2 years ago

This PR will be merged into the releases/v0.5.0 branch to batch the release updates into one PR

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR changes the nature of the fields_to_include argument within the macro to take the inclusion fields as an array [] rather than a string (). This then allows the macro downstream to properly iterate through the inclusion fields. This also allows for a single inclusion field to be added. Adding a single inclusion field was not possible in the previous iteration of the argument.

Does this PR introduce a breaking change?

This PR changes the nature of the fields_to_include argument. The previous version took that argument as a string while this iteration takes the argument as an array (which is preferable). This will cause previous users macros to fail. Thus this will be a breaking change.

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [ ] CircleCi - [ ] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [X] BigQuery - [X] Redshift - [X] Snowflake - [X] Postgres - [X] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** 🧊 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.