search

fivetran / dbt_salesforce_formula_utils

Package containing dbt macros to help generate salesforce formula fields synced from Fivetran.
https://fivetran.github.io/dbt_salesforce_formula_utils/
Apache License 2.0
16 stars 19 forks source link

BUG - Reserved words handling for fields_to_include bugfix #45

Closed fivetran-sheringuyen closed 1 year ago

fivetran-sheringuyen commented 2 years ago

Are you a current Fivetran customer?

Fivetran created

Describe the bug

Posted on dbt/tools-fivetran slack. The new fields_to_include update (0.6.2) is working as expected, however, Salesforce has a table named "case" therefore it creates an issue when referring to the "case" table as an alias within a CASE WHEN statement. We should add an update to handle reserved words.

Package Version

copy packages.yml here

packages:

Warehouse

- [ ] BigQuery - [ ] Redshift - [x] Snowflake (Customer specified issue happening in Snowflake, but could very well be happening in other DBs as well) - [ ] Postgres - [ ] Databricks - [ ] Other (provide details below)
fivetran-joemarkiewicz commented 2 years ago

For context, the dbt Slack conversation and detail of the issue can be seen here.

Further, another customer mentioned a similar issue on dbt Slack in this thread.

Updated to include another customer who is experiencing this same issue. See here for more details.

rob-seaberg commented 2 years ago

Are you a current Fivetran customer?

yes

Describe the bug

I am experiencing the same issue when using sfdc_formula_view for with the salesforce case table. I see that only Snowflake is checked above so I want to flag that it is a BQ issue as well

Package Version

package: fivetran/salesforce_formula_utils
version: 0.6.4

Warehouse

BigQuery

fivetran-joemarkiewicz commented 1 year ago

Hi all,

The using_quoted_identifiers=true argument to the macro which was introduced within the v0.7.2 release of the package should address the reserved word issue raised within this bug report.

As such, I will close this issue and mark as resolved. Please feel free to reopen if the issue still persists.