fivetran / dbt_salesforce_formula_utils

Package containing dbt macros to help generate salesforce formula fields synced from Fivetran.
https://fivetran.github.io/dbt_salesforce_formula_utils/
Apache License 2.0
16 stars 18 forks source link

[Documentation] Macro file name isn't congruent with actual macro name #85

Closed duncan771 closed 1 year ago

duncan771 commented 1 year ago

Is there an existing issue for this?

Describe the issue

Pretty straightforward. There is a macro that has a different file name than the macro itself. This seems counterintuitive. I've gone ahead and created a PR, but it asked to create an issue for it first.

Relevant error log or model output

No response

Expected behavior

The Macro and Macro file would have the same name.

dbt Project configurations

N/A

Package versions

N/A

What database are you using dbt with?

bigquery

dbt Version

1.3.0

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-joemarkiewicz commented 1 year ago

Hi @duncan771 thanks for opening this issue. I agree that this should be renamed to be consistent with the macro name. I will be sure to review your PR in the coming week and will let you know if there are any notes before approving and folding into our next release!

fivetran-catfritz commented 1 year ago

Hi @duncan771, to update you, I will be pulling this into our next release in the next week or so.