Closed fivetran-reneeli closed 1 year ago
This looks good to me! One last thing I noticed is that the integration tests are not actually testing the
view_sql
logic. Would you be able to add the following new row to thefivetran_formula
model within the integration tests seed. This will ensure we are testing theview_sql
(which you updated in this PR) for all tests going forward.account_type_c,opportunity,account type,,"select main__table.id, ( CAST( account__alias.type AS STRING ) ) as account_type_c from opportunity as main__table left join account as account__alias on main__table.account_id = account__alias.id",2023-07-19 05:05:17.411 +0000
Thanks for catching that, added that row to be able to test the view_sql macro
PR Overview
This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_salesforce_formula_utils/issues/91 This PR will result in the following new package version: v0.9.1
Add databricks to the conditional in
sfdc_formula_view_sql
macro so backticks correctly compilePlease detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
This error was missed before because the package wasn't checked to be compatible for the case where full_statement_version=false, only the default true. Therefore we added an additional run in the integration test to use full_statement_version=false. This will recreate and test the issue as well.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
:dancer: