fivetran / dbt_salesforce_source

Fivetran's Salesforce source dbt package
https://fivetran.github.io/dbt_salesforce_source/
Apache License 2.0
11 stars 16 forks source link

FEATURE - Support DataBricks #19

Closed drernie closed 2 years ago

drernie commented 2 years ago

Are you a Fivetran customer? YES (finally) Ernest Prabhakar, IT Biz Apps Manager, Nauto, Inc.

Is your feature request related to a problem? Please describe. We have standardized on DataBricks as our corporate Data Lake. We want to use it with FiveTran

Describe the solution you'd like

Describe alternatives you've considered Rolling my own custom dbt package

Additional context

Please indicate the level of urgency and business impact of this request URGENT This is blocking our adoption of FiveTran inside of Nauto.

Are you interested in contributing to this package?

DONE: https://github.com/fivetran/dbt_salesforce_source/pull/20

drernie commented 2 years ago

FYI, I discovered an acceptable workaround that allows me to run the existing module within my project

  1. Overriding the variables in dbt_project.yml
    vars:
    salesforce_schema: "salesforce"
    salesforce_database: ""
  2. Copying the macro for datediff into macros into this project

    
    {% macro databricks__datediff(first_date, second_date, datepart) %}
    
    DATEDIFF(
        cast({{second_date}} as date),
        cast({{first_date}} as date)
    )

{% endmacro %}

fivetran-joemarkiewicz commented 2 years ago

Hi @drernie thanks so much for opening this issue and the respective PR as well! We really appreciate your contribution 😄

I will review this PR in my next sprint and let you know if I have any questions.

fivetran-joemarkiewicz commented 2 years ago

The latest release integrates databricks support. Closing this request.