fivetran / dbt_salesforce_source

Fivetran's Salesforce source dbt package
https://fivetran.github.io/dbt_salesforce_source/
Apache License 2.0
11 stars 16 forks source link

[Release] Add History Mode Functionality to Salesforce Source Package #40

Closed fivetran-avinash closed 1 year ago

fivetran-avinash commented 1 year ago

PR Overview

This PR will address the following Issue/Feature: This is updaets to include Salesforce History Mode in the existing Salesforce packages.

This PR will result in the following new package version: 0.8.0

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

🍾
fivetran-joemarkiewicz commented 1 year ago

@fivetran-avinash please see PR #41 for my initial review of this update.

fivetran-avinash commented 1 year ago

@fivetran-joemarkiewicz New PR updates applied, in correspondence with your PR notes here.

Changes discussed that were applied.

I think I'm not 100% certain if my source schema setup is correct (to point to either salesforce or salesforce history), so this is what I'd recommend looking at the most in the PR re-review. Also am having some issues making the lineage line up (currently salesforce seeds are pointing toward salesforce history models. I'm wondering if I need to change my model configs).

fivetran-avinash commented 1 year ago

@fivetran-joemarkiewicz New changes addressed! Ignore the generated docs issue, regeneration fixed it all.