search

fivetran / dbt_salesforce_source

Fivetran's Salesforce source dbt package
https://fivetran.github.io/dbt_salesforce_source/
Apache License 2.0
11 stars 16 forks source link

Add order #9

Closed drernie closed 2 years ago

drernie commented 3 years ago

Are you a current Fivetran customer? YES! Ernest Prabhakar, IT Biz Apps Manager, Nauto, Inc.

What change(s) does this PR introduce?

Does this PR introduce a breaking change?

Simply adds new standard Salesforce models (I removed custom fields and DataBricks diffs)

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [ ] CircleCi - [X ] Other (please provide additional testing details below) GitHub DBT Actions (via embedded profile) .github/workflows/dbt-action.yml NOTE: I removed DataBricks dependencies to make this a standalone PR, so I wasn't able to test after that **Select which warehouse(s) were used to test the PR** - [ ] BigQuery - [ ] Redshift - [ ] Snowflake - [ ] Postgres - [X ] Databricks - [ ] Other (provide details below) **Provide an emoji that best describes your current mood** 👼 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 3 years ago

@drernie thanks for opening this PR!

I noticed you added the stg_salesforce__order model. Do you have intentions of transforming this table in downstream models (the transform package)? Or do you wish to just bring this table in with the others in the same package?

Additionally, I noticed you made some updates for Databricks/Spark compatibility. We have actually settled on our standards for this compatibility (see our LinkedIn source PR for an example). If we merge this PR to master we will make these updates on our end.

Let me know what your intentions are on the first question and we can proceed with review/merge following our decisions.

drernie commented 3 years ago

Yes, the goal is to also update a top-level sf package with additional metadata for orders.

This was originally just for internal use, so we'd need to clean out all my custom fields. Let me know how I can best help.

fivetran-joemarkiewicz commented 2 years ago

Hi @drernie thanks so much for opening this. We actually folded a lot of our logic from this PR into the latest release of the Salesforce package!! Please refer to the latest release to see support for the order object. Thanks so much for your contributions 😄