search

fivetran / dbt_servicenow

Fivetran data transformations for ServiceNow built using dbt.
https://fivetran.github.io/dbt_servicenow/
Apache License 2.0
1 stars 1 forks source link

review/jm-initial #1

Closed fivetran-joemarkiewicz closed 9 months ago

fivetran-joemarkiewicz commented 10 months ago

This PR is intended to serve as an initial review of the ServiceNow dbt package. This PR is not intended to be merged into main. Please see the review comments below and address the notes within the main branch. Once the comment has been addressed, please comment as such and do not resolve the comment. I will resolve the comments upon final review.

fivetran-joemarkiewicz commented 9 months ago

Thanks @fivetran-reneeli for going through all of my review notes and applying the necessary changes! This package is looking great and should be ready to go with just a few minor last minute edits. I will close out this PR, but if you can review and merge in PR #2 to address the last minute changes that would be great!

Let me know if you have any questions. We can then discuss release plans.