Closed fivetran-joemarkiewicz closed 1 year ago
Also, should we remove variant_fulfillment_service
from shopify__order_lines
and shopify__inventory_levels
, if that fulfillment_services
field gets removed from the upstream product_variant
model.
Finally, I'm noticing no models are showing up under files changed, for the ones with fields that are supposed to be removed. But I don't see the to-be removed fields in those models on this branch anyways... I must be missing something?
- Also, should we remove
variant_fulfillment_service
fromshopify__order_lines
andshopify__inventory_levels
, if thatfulfillment_services
field gets removed from the upstreamproduct_variant
model.
- Finally, I'm noticing no models are showing up under files changed, for the ones with fields that are supposed to be removed. But I don't see the to-be removed fields in those models on this branch anyways... I must be missing something?
select *
in the respective models which now are returning less fields. As such, no models need to be changed but the ymls have been updated.Thanks for explaining!
One last thing is I still don't see the shopify_using_shop_metafields
bit in the readme
Thanks for explaining!
One last thing is I still don't see the
shopify_using_shop_metafields
bit in the readme
@fivetran-reneeli the metafield section is here
Got it! Ok, looks good to go
PR Overview
This PR will address the following Issue/Feature: Issue #60 and Issue #67
This PR will result in the following new package version:
v0.9.0
This is not technically a breaking change, but due to the upstream changes in the source, this is considered breaking.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
These changes are made breaking due to changes in the source.
lifetime_duration
fulfillment_service
destination_location_*
fieldsorigin_location_*
fieldstotal_price_usd
processing_method
lifetime_duration
lifetime_duration
fulfillment_service
destination_location_*
fieldsorigin_location_*
fieldstotal_price_usd
processing_method
Documentation Updates
shopify_using_shop_metafields
variable was added to the Adding Metafields of the README. It was erroneously omitted in a previous release.current_total_price
yml definition from the shopify__orders model as it was not being created in the model.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Not much validation was needed for these changes. I used the release notes as the basis for what fields were being deprecated. I then removed these fields from the staging models, macros, and yml documentation from the source package and then made similar adjustments to this package. I then ran the models and confirmed the fields were no longer present and that no errors resulted from the removal of the upstream fields in the downstream models. No further validation was necessary per my opinion.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🛫