This PR will address the following Issue/Feature: #77
This PR will result in the following new package version:
This will merge into a v.12.0 branch that @fivetran-catfritz is working on.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🪲 Bug Fixes 🪛
Corrected the fixed_amount_discount_amount logic to appropriately bring in fixed amount discounts in shopify__orders. PR #78
Removed the index=1 filter in stg_shopify__order_discount_code in the dbt_shopify_source package to ensure all discount codes are brought in for every orders. For customers with multiple discount codes in an order, this could update the count_discount_codes_applied field in the shopify__orders and shopify__daily_shop models. PR #80
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt run –full-refresh && dbt test
[NA] dbt run (if incremental models are present)
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[Catherine will regenerate before release] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[x] Detailed validation steps have been provided below
Detailed Validation
Please share any and all of your validation steps:
Seeded and ran the updated files from integration_tests with fixed_amount to make sure that fixed_amount_discount_amount was bringing in the right values, and ensure that count_discount_codes_applied was also correct per order_id.
PR Overview
This PR will address the following Issue/Feature: #77
This PR will result in the following new package version:
This will merge into a v.12.0 branch that @fivetran-catfritz is working on.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🪲 Bug Fixes 🪛
fixed_amount_discount_amountlogic to appropriately bring in fixed amount discounts inshopify__orders. PR #78index=1filter instg_shopify__order_discount_codein thedbt_shopify_sourcepackage to ensure all discount codes are brought in for every orders. For customers with multiple discount codes in an order, this could update thecount_discount_codes_appliedfield in theshopify__ordersandshopify__daily_shopmodels. PR #80🔧 Under the Hood 🔩
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Seeded and ran the updated files from
integration_testswithfixed_amountto make sure thatfixed_amount_discount_amountwas bringing in the right values, and ensure thatcount_discount_codes_appliedwas also correct perorder_id.