feature/variable_calendar_start

fivetran-reneeli commented 2 months ago

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_shopify/issues/64

This PR will result in the following new package version:

v0.12.2

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature: Customizable date start

Updated the shopifycalendar start date to include a variable `shopifycalendar_start_date. This can be set in your dbt_project.yml. If not used, the default will start at2019-01-01`. See the README for more details.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

[x] dbt run –full-refresh && dbt test
[x] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[ ] Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Tested by configuring the variable and running against internal data

If you had to summarize this PR in an emoji, which would it be?

:dancer:

fivetran-reneeli commented 2 months ago

will wait to regen docs til approved

fivetran-reneeli commented 1 month ago

Thanks @fivetran-joemarkiewicz ! And yeah for validations, I left the variable I had tested with in our internal notes but definitely could've screenshotted what I was looking at since there's no PII, noted for future reference.

fivetran / dbt_shopify