fivetran / dbt_shopify_source

Fivetran's Shopify source dbt package
https://fivetran.github.io/dbt_shopify_source/
Apache License 2.0
29 stars 23 forks source link

[Schema Change] <Shopify API Update 2022> #46

Closed manhitv closed 1 year ago

manhitv commented 1 year ago

Is there an existing issue for this?

Describe the issue

I have received information that Shopify has made some updates related to changing the schema of some tables, including the Shopify customers table (as shown in the figure below).

unnamed

I have checked the new ERD and found that the deprecated columns are still there and it does not affect the operation of the current dbt_shopify too seriously. However, I want to update my data pipeline (using the dbt_shopify package) according to the latest updates, specifically update this mapping relation in shopify_customer table:

email_marketing_consent_state --> has_accept_marketing

instead of

accept_marketing -->has_accept_marketing

as I am seeing here https://github.com/ fivetran/dbt_shopify_source/blob/main/macros/staging_columns.sql.

Relevant error log or model output

No response

Expected behavior

Update this mapping relation in shopify_customer table:

email_marketing_consent_state --> has_accept_marketing

instead of

accept_marketing -->has_accept_marketing

dbt Project configurations

name: 'fivetran_shopify' version: '1.0.0' config-version: 2

Package versions

packages:

What database are you using dbt with?

bigquery

dbt Version

None

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-jamie commented 1 year ago

hey there! so i am currently working on updates to the Shopify package that i believe capture what you're looking for.

the mapping occurs on this branch here -- what do you think? @manhitv

manhitv commented 1 year ago

Oh thanks @fivetran-jamie. It looks like my problem will be solved immediately after the update but the output table schema will be changed a little (from _has_acceptmarketing to _marketing_consentstate), isn't it? May I know when there is a new version so I can update?

Thank you in advance.

fivetran-jamie commented 1 year ago

yes and yes! will ping you here when it's live

manhitv commented 1 year ago

Thank you so much, @fivetran-jamie.