fivetran-joemarkiewicz
commented
1 year ago Hi @jarlisle thanks so much for opening this pull request to adjust the severity of the test!
Our team is actually currently working on PR #59 which will include a pretty neat update that will address this very bug you are patching in this PR. Instead of inserting a null record into the staging model if the source doesn't exist, we perform a limit 0 which will effectively ensure this test does not fail for users who do not have discounts.
Therefore, for users that do still have discounts, this test will appropriately fail if their source data is not complete. I would recommend keeping a close eye on Issue #57 as we will likely share an update soon and work to push the fix in the coming week. If you have anything else you would like to share, it would be great to add in that thread!
For the time being, I would recommend configuring this test to be disabled via your root dbt_project.yml.
Are you a current Fivetran customer? Jared Carlisle, adMind LLC
What change(s) does this PR introduce? This changes the severity of a test on discount_code_id being null to warn. This is due to the fact that if the source table does not exist the code inserts a record where the discount_code_id is null, which would result in the test failing all the time.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.