search

fivetran / dbt_shopify_source

Fivetran's Shopify source dbt package
https://fivetran.github.io/dbt_shopify_source/
Apache License 2.0
29 stars 23 forks source link

Update stg_shopify__metafield.sql #63

Closed ZCrookston closed 1 year ago

ZCrookston commented 1 year ago

resolves an ambiguous column error when the namespace or key fields have inconsistent casing (capital vs lower case names).

Are you a current Fivetran customer? adMind

What change(s) does this PR introduce? Resolves an error

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 1 year ago

HI @ZCrookston thanks for opening this PR! Would you be able to provide some more context around the error you are currently encountering and how this update addresses the issue?

From there I will be able to review once all is ready in your patch!

ZCrookston commented 1 year ago

Thank you for the quick response! I just opened an issue with some more context.

https://github.com/fivetran/dbt_shopify_source/issues/64

fivetran-avinash commented 1 year ago

Hi @ZCrookston ! Thanks for providing your PR! We've merged it into our existing branch to fix this issue and we will be sure to give you credit for all your contributions here. We'll let you know how to test this in the issue discussion thread.