This PR will result in the following new package version:
0.8.3
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Lower casing metafield_reference field in stg_shopify__metafield to fix metafield table breakages upstream when the key field has different casing for otherwise identical strings.
Lower casing owner_resource field in stg_shopify__metafield to ensure identical value fields with different casing are then correctly pivoted together upstream in the shopify transformation package get_metafields macro.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt compile
[x] dbt run –full-refresh
[x] dbt run
[x] dbt test
[N/A] dbt run –vars (if applicable)
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked and tagged
[x] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[x] You have provided details below around the validation steps performed to gain confidence in these changes.
Our development data is limited for testing, but the most important thing is to show that the before-and-after result in stg_shopify__metafield and `shopify__shop_metafields.sql is the same. You will want to test the master and the current branch against each other to validate the results hold. Since the customer has already tested out one of these changes on their own side, this should be enough to validate these changes will achieve the intended result.
See the Height ticket for more details.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[x] indexed within dbt_project.yml
[x] indexed within integration_tests/dbt_project.yml
[x] CHANGELOG has individual entries for each respective change in this PR
[N/A] README updates have been applied (if applicable)
[N/A] DECISIONLOG updates have been updated (if applicable)
[N/A] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[x] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature:
64
This PR will result in the following new package version:
0.8.3
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
metafield_referencefield instg_shopify__metafieldto fix metafield table breakages upstream when thekeyfield has different casing for otherwise identical strings.owner_resourcefield instg_shopify__metafieldto ensure identicalvaluefields with different casing are then correctly pivoted together upstream in the shopify transformation packageget_metafieldsmacro.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Our development data is limited for testing, but the most important thing is to show that the before-and-after result in
stg_shopify__metafieldand `shopify__shop_metafields.sql is the same. You will want to test the master and the current branch against each other to validate the results hold. Since the customer has already tested out one of these changes on their own side, this should be enough to validate these changes will achieve the intended result.See the Height ticket for more details.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
⬇️