fivetran / dbt_shopify_source

Fivetran's Shopify source dbt package
https://fivetran.github.io/dbt_shopify_source/
Apache License 2.0
29 stars 23 forks source link

Remove order discount code filter, add index in #81

Closed fivetran-avinash closed 4 months ago

fivetran-avinash commented 4 months ago

PR Overview

This PR will address the following Issue/Feature: #80

This PR will result in the following new package version:

This will merge into a v.12.0 branch that @fivetran-catfritz is working on.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

πŸͺ² Bug Fixes πŸͺ›

πŸ”§ Under the Hood πŸ”©

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please share any and all of your validation steps:

Added index=2 and index=3 rows to order_discount_code.csv to ensure additional indices were brought in, as well as test and see if the new uniqueness test passed.

fivetran-avinash commented 4 months ago

@fivetran-avinash this generally looks good, but I have one small question around the test update. Would you be able to take a look and share your thoughts. Let me know once you have responded and I can give a final review.

@fivetran-joemarkiewicz Answered, hopefully that makes sense.