Closed fivetran-avinash closed 4 months ago
@fivetran-avinash this generally looks good, but I have one small question around the test update. Would you be able to take a look and share your thoughts. Let me know once you have responded and I can give a final review.
@fivetran-joemarkiewicz Answered, hopefully that makes sense.
PR Overview
This PR will address the following Issue/Feature: #80
This PR will result in the following new package version:
This will merge into a v.12.0 branch that @fivetran-catfritz is working on.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
πͺ² Bug Fixes πͺ
index
filter instg_shopify__order_discount_code
, as we were erroneously filtering out multiple discounts for an order sinceindex
is meant to pair withorder_id
as the unique identifier for this source. PR #80index
as a field instg_shopify__order_discount_code
, as it is part of the primary key. PR #80π Documentation Updates π
index
documentation to oursrc_shopify.yml
andstg_shopify.yml
. PR #80unique_combination_of_columns
test to correctly check onindex
withorder_id
andsource_relation
. PR #80π§ Under the Hood π©
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Added index=2 and index=3 rows to
order_discount_code.csv
to ensure additional indices were brought in, as well as test and see if the new uniqueness test passed.