search

fivetran / dbt_shopify_source

Fivetran's Shopify source dbt package
https://fivetran.github.io/dbt_shopify_source/
Apache License 2.0
29 stars 23 forks source link

adding product_id to uniqueness test #86

Closed ryan-brainforge closed 3 months ago

ryan-brainforge commented 3 months ago

Please provide your name and company Ryan - Brainforge

Link the issue/feature request which this PR is meant to address Issue 85

Detail what changes this PR introduces and how this addresses the issue/feature request linked above. This PR updates the uniqueness test to the stg_shopify__product_image model by adding the product_id field as part of the unique combination_of_columns test

How did you validate the changes introduced within this PR? I ran the updated test with the product_id locally with the same data that was initially failing, and it passed

Which warehouse did you use to develop these changes? Snowflake

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)
fivetran-jamie commented 3 months ago

hey there @ryan-brainforge, thanks for opening this 🙌 i'll go ahead and review and merge this into a release branch to push out with some other updates early next week!